Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PR template to include an acceptance test #2614

Merged
merged 1 commit into from Jan 17, 2019

Conversation

nikkictl
Copy link

Signed-off-by: Nikki Attea nikki@sensu.io

What is this change?

Adds a section to the PR template to include a test case.

Why is this change necessary?

New QA process.

Does your change need a Changelog entry?

Nah.

Do you need clarification on anything?

Nah.

Were there any complications while making this change?

Nah.

Have you reviewed and updated the documentation for this change? Is new documentation required?

We good.

Signed-off-by: Nikki Attea <nikki@sensu.io>
Copy link

@annaplotkin annaplotkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@nikkictl nikkictl merged commit b068bde into master Jan 17, 2019
@nikkictl nikkictl deleted the template-test-case branch January 17, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants