Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2357: Updated viper to v1.3.2 to mitigate this issue. #2867

Closed
wants to merge 2 commits into from
Closed

#2357: Updated viper to v1.3.2 to mitigate this issue. #2867

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2019

What is this change?

Update viper to mitigate:
#2357
spf13/viper#200

Why is this change necessary?

When --labels "hey=now" is used sensuctl entity info shows labels as null... even if labels are set in agent.yaml

Does your change need a Changelog entry?

Update viper to mitigate

Do you need clarification on anything?

N/A.

Were there any complications while making this change?

N/A.

Have you reviewed and updated the documentation for this change? Is new documentation required?

No.

How did you verify this change?

Local testing.

@echlebek
Copy link
Contributor

echlebek commented Apr 9, 2019

Hi thanks for sending us this PR.

Unfortunately, the build is failing because of missing dependencies.

sensu-go uses dep for managing dependencies. If you want to upgrade a dependency, find it in Gopkg.toml, change the version number, and run dep ensure in the repository root. This should get things building again.

As a contributor to the project you will also need to sign your commits with DCO. See CONTRIBUTING.md for more information on DCO.

@echlebek echlebek self-requested a review April 9, 2019 18:31
@echlebek echlebek mentioned this pull request Apr 15, 2019
@echlebek
Copy link
Contributor

I've submitted a PR that upgrades viper to 1.3.2, so I'll close this one out in favour of that one.

@echlebek echlebek closed this Apr 15, 2019
@ghost
Copy link
Author

ghost commented Apr 15, 2019

Thank you @echlebek. I’ll follow your process in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant