Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing sensu_contact (and other types) with sensu_sorted_json() #729

Closed
3 tasks
jeffmccune opened this issue Jul 11, 2017 · 1 comment
Closed
3 tasks
Labels

Comments

@jeffmccune
Copy link
Collaborator

jeffmccune commented Jul 11, 2017

This came up in the discussion of #728 which implements #597. We're aware most of the native and defined types in the sensu module effectively pass-through data to the underlying JSON configuration files.

In an effort to make it easier and less work to maintain the Puppet module, consider making each of the defined types generic enough to pass-through configuration data as-is using sorted JSON.

The goal is to:

  • Make the sensu-puppet module future-compatible with sensu. That is, as new configuration attributes are added, this data should be able to flow-through the defined types. e.g. using a generic "config" attribute which accepts a Hash value.
  • Normalize the existing defined types to share behavior
  • Reduce the number of Ruby implemented custom types and providers to make it easier to add new defined types using pure Puppet code only.
@ghoneycutt
Copy link
Collaborator

Let's target this when we transition the module to support Sensu 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants