Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sensu Go 5.6 #1105

Merged
merged 4 commits into from May 6, 2019
Merged

Support Sensu Go 5.6 #1105

merged 4 commits into from May 6, 2019

Conversation

treydock
Copy link
Collaborator

@treydock treydock commented May 5, 2019

Pull Request Checklist

Description

  • Fix issue when sensuctl list returns null
  • Use shared code to handle parsing output from sensuctl list
  • Support trusted_ca_file, client_cert_file and client_key_file for AD and LDAP auth
  • Make server_binding optional for AD and LDAP auth

Related Issue

Works around issue sensu/sensu-go#2915

Motivation and Context

Sensu-Go 5.6 made AD and LDAP authentication optional. Also new properties for AD and LDAP were added to supply CA certs and keys. An issue was discovered where sensuctl <resource> list will return null instead of empty array and this PR addresses that and moves the JSON parsing logic to shared function.

How Has This Been Tested?

Unit and acceptance

Use shared code to handle parsing output from sensuctl <resource> list
@treydock
Copy link
Collaborator Author

treydock commented May 5, 2019

Added commit that should fix failures with clusters. The JSON from --format json for cluster commands is actually two separate JSON structures so updated logic to handle old and new formats.

@ghoneycutt ghoneycutt merged commit 5c16abd into master May 6, 2019
@ghoneycutt ghoneycutt deleted the support-5.6 branch May 6, 2019 23:21
@treydock treydock removed the bug label May 7, 2019
@ghoneycutt
Copy link
Collaborator

Released in v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants