Add Windows support for Sensu Go agent #1108

treydock · 2019-05-10T23:24:05Z

Pull Request Checklist

Description

Add Windows support for agent

Related Issue

Fixes #1106

Motivation and Context

Sensu Go 5.7 added better support for Windows, this PR adds that support.

treydock · 2019-05-10T23:28:40Z

Added to travis and appveyor configs limit on what builds. Previously if I pushed to this repo a branch then open a PR there would be two sets of builds. Now PRs, master and tags are what build so if I open a PR there is only going to be one set of builds and not two.

treydock · 2019-05-11T13:05:21Z

@ghoneycutt Was contemplating simplifying parameters and just have package_source and if it starts with http or https then download with archive.

treydock · 2019-05-11T15:19:43Z

I am working on adding acceptance tests for facts on Windows to ensure they work but not having much luck. It works with Vagrant image but having issues getting stdout to return actual output with serverspec.

treydock · 2019-05-11T17:16:24Z

Got commit added that tests sensu_agent fact for Windows.

.fixtures.yml

README.md

Rakefile

README.md

appveyor.yml

Vagrantfile

appveyor.yml

spec/acceptance/windows_spec.rb

spec/classes/agent_spec.rb

spec/classes/backend_spec.rb

REFERENCE.md

ghoneycutt · 2019-05-13T17:23:47Z

appveyor.yml

+  matrix:
+    - PUPPET_GEM_VERSION: '~>5.x'
+      PUPPET_REPO: puppet5
+      PUPPET_VERSION: 5.5.14


does this have to be hard coded? we can't just pull the latest minor version?

Puppetlabs doesn't provide a latest type MSI path so what we have are exact versions: https://downloads.puppetlabs.com/windows/puppet5/. We also can't use one installed via Gem, we are testing real Puppet install that gets installed into system locations like one would do when dealing with real Windows server. That value for PUPPET_VERSION gets added to MSI download URL, not something coming from rubygems.org.

they do provide latest..

https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-x64-latest.msi

https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-x86-latest.msi

No idea how I missed that, I updated appveyor configs to use those latest URLs.

tests/sensu-agent.pp

REFERENCE.md

ghoneycutt · 2019-05-15T17:16:26Z

Vagrant is failing due to Puppet re-organizing their repo's.

ghoneycutt · 2019-05-16T17:59:34Z

This is failing vagrant with

==> win2012r2-agent: Configuring proxy environment variables...
The following WinRM command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mkdir "/" -force

Stdout from the command:



Stderr from the command:

The path is not of a legal form.
At line:1 char:1
+ mkdir "/" -force
+ ~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (C:\:String) [New-Item], ArgumentException
    + FullyQualifiedErrorId : CreateDirectoryArgumentError,Microsoft.PowerShell.Commands.NewItemCommand

treydock · 2019-05-16T19:33:11Z

I used win2012r2-agent to build the Windows logic so worked on my end. I'd check plugins that might be present and causing extra logic to get executed that is Linux specific. I think only plugins I have are one for adding guest additions and maybe the reload plugin.

ghoneycutt · 2019-05-16T22:52:47Z

Removing vagrant-proxyconf plugin got past that error. Now though I'm seeing this.

==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: tests/provision_basic_win.ps1 as c:\tmp\vagrant-shell.ps1
    win2012r2-agent: Installing Puppet from https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-5.5.6-x64.msi
    win2012r2-agent: Log will be written to C:/vagrant/puppet-agent.log
    win2012r2-agent: symbolic link created for C:\ProgramData\PuppetLabs\code\environments\production\modules\sensu <<===>> C:\vagrant
    win2012r2-agent: Out-File : Could not find a part of the path
    win2012r2-agent: 'C:\ProgramData\PuppetLabs\puppet\etc\hiera.yaml'.
    win2012r2-agent: At C:\tmp\vagrant-shell.ps1:36 char:18
    win2012r2-agent: + $hiera_content | Out-File -FilePath "$hiera_file" -Encoding ascii
    win2012r2-agent: +                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    win2012r2-agent:     + CategoryInfo          : OpenError: (:) [Out-File], DirectoryNotFoundExce
    win2012r2-agent:    ption
    win2012r2-agent:     + FullyQualifiedErrorId : FileOpenFailure,Microsoft.PowerShell.Commands.Ou
    win2012r2-agent:    tFileCommand
    win2012r2-agent: puppet : The term 'puppet' is not recognized as the name of a cmdlet,
    win2012r2-agent: function, script file, or operable program. Check the spelling of the name, or
    win2012r2-agent: if a path was included, verify that the path is correct and try again.
    win2012r2-agent: At line:1 char:1
    win2012r2-agent: + puppet module install puppetlabs-stdlib
    win2012r2-agent: + ~~~~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (puppet:String) [], CommandNotFo
    win2012r2-agent:    undException
    win2012r2-agent:     + FullyQualifiedErrorId : CommandNotFoundException
    win2012r2-agent: puppet : The term 'puppet' is not recognized as the name of a cmdlet,
    win2012r2-agent: function, script file, or operable program. Check the spelling of the name, or
    win2012r2-agent: if a path was included, verify that the path is correct and try again.
    win2012r2-agent: At line:1 char:1
    win2012r2-agent: + puppet module install puppet-archive
    win2012r2-agent: + ~~~~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (puppet:String) [], CommandNotFo
    win2012r2-agent:    undException
    win2012r2-agent:     + FullyQualifiedErrorId : CommandNotFoundException
    win2012r2-agent: Copy-Item : Cannot find path 'C:\vagrant\tests\ssl' because it does not exist.
    win2012r2-agent: At C:\tmp\vagrant-shell.ps1:45 char:1
    win2012r2-agent: + Copy-Item -Path "C:\vagrant\tests\ssl\*" -Destination
    win2012r2-agent: "C:\ProgramData\PuppetLabs ...
    win2012r2-agent: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    win2012r2-agent: ~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (C:\vagrant\tests\ssl:String) [C
    win2012r2-agent:    opy-Item], ItemNotFoundException
    win2012r2-agent:     + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.CopyI
    win2012r2-agent:    temCommand
    win2012r2-agent: puppet : The term 'puppet' is not recognized as the name of a cmdlet,
    win2012r2-agent: function, script file, or operable program. Check the spelling of the name, or
    win2012r2-agent: if a path was included, verify that the path is correct and try again.
    win2012r2-agent: At line:1 char:1
    win2012r2-agent: + puppet resource host sensu-backend.example.com ensure=present
    win2012r2-agent: ip=192.168.52.10
    win2012r2-agent: + ~~~~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (puppet:String) [], CommandNotFo
    win2012r2-agent:    undException
    win2012r2-agent:     + FullyQualifiedErrorId : CommandNotFoundException
==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: inline PowerShell script
    win2012r2-agent: puppet : The term 'puppet' is not recognized as the name of a cmdlet,
    win2012r2-agent: function, script file, or operable program. Check the spelling of the name, or
    win2012r2-agent: if a path was included, verify that the path is correct and try again.
    win2012r2-agent: At line:1 char:1
    win2012r2-agent: + puppet apply -v C:/vagrant/tests/sensu-agent.pp
    win2012r2-agent: + ~~~~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (puppet:String) [], CommandNotFo
    win2012r2-agent:    undException
    win2012r2-agent:     + FullyQualifiedErrorId : CommandNotFoundException
==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: inline PowerShell script
    win2012r2-agent: facter : The term 'facter' is not recognized as the name of a cmdlet,
    win2012r2-agent: function, script file, or operable program. Check the spelling of the name, or
    win2012r2-agent: if a path was included, verify that the path is correct and try again.
    win2012r2-agent: At C:\tmp\vagrant-shell.ps1:1 char:1
    win2012r2-agent: + facter --custom-dir=C:
                                             agrantlib
                                                      acter sensu_agent
    win2012r2-agent: + ~~~~~~
    win2012r2-agent:     + CategoryInfo          : ObjectNotFound: (facter:String) [], CommandNotFo
    win2012r2-agent:    undException
    win2012r2-agent:     + FullyQualifiedErrorId : CommandNotFoundException

treydock · 2019-05-16T23:31:54Z

Try destroying and then re-running vagrant up win2012r2-agent to see if that solves your issue. I destroyed my instance and ran into no problems:

==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: tests/provision_basic_win.ps1 as c:\tmp\vagrant-shell.ps1
    win2012r2-agent: Installing Puppet from https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-5.5.6-x64.msi
    win2012r2-agent: Log will be written to C:/vagrant/puppet-agent.log
    win2012r2-agent: symbolic link created for C:\ProgramData\PuppetLabs\code\environments\production\modules\sensu <<===>> C:\vagrant
    win2012r2-agent: Notice: Preparing to install into C:/ProgramData/PuppetLabs/code/environments/production/modules ...
    win2012r2-agent: Notice: Downloading from https://forgeapi.puppet.com ...
    win2012r2-agent: Notice: Installing -- do not interrupt ...
    win2012r2-agent: C:/ProgramData/PuppetLabs/code/environments/production/modules
    win2012r2-agent: â””â”€â”€ puppetlabs-stdlib (v5.2.0)
    win2012r2-agent: Notice: Preparing to install into C:/ProgramData/PuppetLabs/code/environments/production/modules ...
    win2012r2-agent: Notice: Downloading from https://forgeapi.puppet.com ...
    win2012r2-agent: Notice: Installing -- do not interrupt ...
    win2012r2-agent: C:/ProgramData/PuppetLabs/code/environments/production/modules
    win2012r2-agent: â””â”€â”¬ puppet-archive (v3.2.1)
    win2012r2-agent:   â””â”€â”€ puppetlabs-stdlib (v5.2.0)
    win2012r2-agent: Notice: /Host[sensu-backend.example.com]/ensure: created
    win2012r2-agent: host { 'sensu-backend.example.com':
    win2012r2-agent:   ensure => 'present',
    win2012r2-agent:   ip     => '192.168.52.10',
    win2012r2-agent:   target => 'C:/Windows/System32/drivers/etc/hosts',
    win2012r2-agent: }
==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: inline PowerShell script
    win2012r2-agent: Info: Loading facts
    win2012r2-agent: Info: Loading facts
    win2012r2-agent: Info: Loading facts
    win2012r2-agent: Notice: Compiled catalog for win2012r2-agent in environment production in 1.31 seconds
    win2012r2-agent: Info: Applying configuration version '1558049378'
    win2012r2-agent: Notice: /Stage[main]/Sensu::Agent/Archive[sensu-go-agent.msi]/ensure: download archive from https://s3-us-west-2.amazonaws.com/sensu.io/sensu-go/5.7.0/sensu-go-agent_5.7.0.2380_en-US.x64.msi to C:\\sensu-go-agent_5.7.0.2380_en-US.x64.msi  without cleanup
    win2012r2-agent: Notice: /Stage[main]/Sensu::Agent/Package[sensu-go-agent]/ensure: created
    win2012r2-agent: Info: Computing checksum on file C:/ProgramData/Sensu/config/agent.yml.example
    win2012r2-agent: Info: /Stage[main]/Sensu/File[C:/ProgramData/Sensu/config/agent.yml.example]: Filebucketed C:/ProgramData/Sensu/config/agent.yml.example to puppet with sum 97e32c0f771b215986e8851de517171e
    win2012r2-agent: Notice: /Stage[main]/Sensu/File[C:/ProgramData/Sensu/config/agent.yml.example]/ensure: removed
    win2012r2-agent: Notice: /Stage[main]/Sensu::Ssl/File[sensu_ssl_dir]/ensure: created
    win2012r2-agent: Notice: /Stage[main]/Sensu::Ssl/File[sensu_ssl_ca]/ensure: defined content as '{md5}cd478579a6abb9f24ee3035bb1cdbc19'
    win2012r2-agent: Info: Class[Sensu::Ssl]: Scheduling refresh of Service[sensu-agent]
    win2012r2-agent: Notice: /Stage[main]/Sensu::Agent/File[sensu_agent_config]/ensure: defined content as '{md5}7f14d98043a5df0e1c69749d2bc1c681'
    win2012r2-agent: Info: /Stage[main]/Sensu::Agent/File[sensu_agent_config]: Scheduling refresh of Service[sensu-agent]
    win2012r2-agent: Notice: /Stage[main]/Sensu::Agent/Exec[install-agent-service]/returns: executed successfully
    win2012r2-agent: Notice: /Stage[main]/Sensu::Agent/Service[sensu-agent]: Triggered 'refresh' from 2 events
    win2012r2-agent: Notice: Applied catalog in 22.12 seconds
==> win2012r2-agent: Running provisioner: shell...
    win2012r2-agent: Running: inline PowerShell script
    win2012r2-agent: {
    win2012r2-agent:   version => "5.7.1",
    win2012r2-agent:   build => "5bf304b4e215f46cbcf30c7d5e73486d570dfaf6",
    win2012r2-agent:   built => "2019-05-06T20:53:02Z"
    win2012r2-agent: }

Fixes #1106

Allow latest fixtures unit tests to fail

treydock · 2019-05-16T23:37:50Z

Modified windows provisioning for vagrant to use latest windows URL for 5.x of Puppet.

ghoneycutt · 2019-05-17T02:49:24Z

Success with all the windows versions in vagrant. Waiting on Travis then good to merge.

treydock force-pushed the windows branch from c0dcd0a to 9024f72 Compare May 10, 2019 23:27

treydock force-pushed the windows branch from 9024f72 to 0b7aabb Compare May 10, 2019 23:41

treydock mentioned this pull request May 11, 2019

Fix cluster tests to work with Sensu Go 5.7 #1109

Merged

treydock force-pushed the windows branch from 0b7aabb to 6b7b032 Compare May 11, 2019 00:08

treydock added the sensu-go label May 11, 2019

treydock force-pushed the windows branch from f359ccb to 781e806 Compare May 11, 2019 13:37

treydock requested a review from ghoneycutt May 11, 2019 13:38

treydock force-pushed the windows branch 2 times, most recently from 43ab8dc to 781e806 Compare May 11, 2019 14:58