BREAKING: Refactor how sensu_ldap_auth and sensu_ad_auth define servers #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
auth-refactor
branch
from
d0448c6
to
f66ab0c
Compare
This was referenced Sep 5, 2019
ghoneycutt
changed the title
treydock
force-pushed
the
auth-refactor
branch
from
f66ab0c
to
c90d786
Compare
Move server_binding, server_group_search and server_user_search into servers property
treydock
force-pushed
the
auth-refactor
branch
from
c90d786
to
1c2769c
Compare
ghoneycutt
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Refactor
sensu_ldap_authandsensu_ad_authon how properties are defined.Move server_binding, server_group_search and server_user_search into servers property
Motivation and Context
This makes the
serversproperty match the Sensu Go docs for LDAP and AD authentication specs.