New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release process #1166
Improve release process #1166
Conversation
1. Build module with `puppet module build` | ||
1. Upload module to Puppet Forge. | ||
1. Run Rake task to release module: `bundle exec rake release` | ||
1. Push to master with tags: `git push --tags` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this only pushes the tags. Still needs step commit changes and push to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rake task does the commit. I am pretty sure that if you omit origin master
from push
then the default of just git push
to the same as git push origin <current branch>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I push other modules I do git push --tags origin master
but based on usage spec for git push
the origin
and master
are optional as they are default if on master branch.
65a1ee3
to
cd961eb
Compare
Added change that borrowed from PDK Rakefile where Github Labels will have different headers in CHANGELOG, so it's clearer which changes are breaking vs enhancement vs bug fixes. Currently all pull requests are just bundled together and not very meaningful. |
restarted the two stuck jobs |
All tests now passing. |
Going to follow these directions test by doing a release. |
Pull Request Checklist
Description
Simplify release process into 3 steps
rake release
taskMotivation and Context
Streamline release process and also deploy Forge module as part of Travis workflow. If all tests pass and the build is for a tag, the module will be pushed to the forge.
How Has This Been Tested?
I have only run local tests with the strings task in release task commented out