Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release process #1166

Merged
merged 2 commits into from Nov 12, 2019
Merged

Improve release process #1166

merged 2 commits into from Nov 12, 2019

Conversation

treydock
Copy link
Collaborator

@treydock treydock commented Nov 5, 2019

Pull Request Checklist

Description

Simplify release process into 3 steps

  1. Update version in metadata.json
  2. Run rake release task
  3. Push tags and commit to github

Motivation and Context

Streamline release process and also deploy Forge module as part of Travis workflow. If all tests pass and the build is for a tag, the module will be pushed to the forge.

How Has This Been Tested?

I have only run local tests with the strings task in release task commented out

.travis.yml Show resolved Hide resolved
1. Build module with `puppet module build`
1. Upload module to Puppet Forge.
1. Run Rake task to release module: `bundle exec rake release`
1. Push to master with tags: `git push --tags`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this only pushes the tags. Still needs step commit changes and push to master.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rake task does the commit. I am pretty sure that if you omit origin master from push then the default of just git push to the same as git push origin <current branch>.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I push other modules I do git push --tags origin master but based on usage spec for git push the origin and master are optional as they are default if on master branch.

@treydock treydock force-pushed the release branch 6 times, most recently from 65a1ee3 to cd961eb Compare November 9, 2019 16:54
@treydock
Copy link
Collaborator Author

Added change that borrowed from PDK Rakefile where Github Labels will have different headers in CHANGELOG, so it's clearer which changes are breaking vs enhancement vs bug fixes. Currently all pull requests are just bundled together and not very meaningful.

@ghoneycutt
Copy link
Collaborator

restarted the two stuck jobs

@treydock
Copy link
Collaborator Author

All tests now passing.

@ghoneycutt ghoneycutt merged commit 5d3649f into master Nov 12, 2019
@ghoneycutt ghoneycutt deleted the release branch November 12, 2019 18:51
@ghoneycutt
Copy link
Collaborator

Going to follow these directions test by doing a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants