Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows 2019 #1168

Merged
merged 1 commit into from Nov 12, 2019
Merged

Support Windows 2019 #1168

merged 1 commit into from Nov 12, 2019

Conversation

treydock
Copy link
Collaborator

@treydock treydock commented Nov 9, 2019

Pull Request Checklist

Description

Add Support for Windows 2019

Motivation and Context

Sensu Go says "2008 R2 and later" and now Appveyor has Windows 2019 images.

@ghoneycutt
Copy link
Collaborator

This is great! This should also be in the README under Limitations.

@treydock
Copy link
Collaborator Author

Limitations doesn't document supported platforms, but a different place in README does and added Windows versions to that list.

* Windows Server 2008 R2
* Windows Server 2012 R2
* Windows Server 2016
* Windows Server 2019
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get it added to Vagrant as well.

@ghoneycutt
Copy link
Collaborator

An appveyor test is failing and I can't tell if it is transient or not. Not able to restart the job. Should restart though when you rebase/squash with the Vagrant addition.

@treydock
Copy link
Collaborator Author

There are no reliable Windows 2019 Vagrant boxes. I haven't managed to get any to work. I think we will just have to rely on Appveyor for testing Windows 2019. The appveyor failure is transient but I can't see output until #1164 is merged which fixes appveyor to not omit output. This PR just added items to test matrix and one of the old tests failed so see no way it could be related, especially since previous commit was passing and all I changed was README.

@ghoneycutt ghoneycutt merged commit 8d84670 into master Nov 12, 2019
@ghoneycutt ghoneycutt deleted the win2019 branch November 12, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants