Use puppet5 to provision debian based vagrant boxes #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing Travis |
|
Looks like sensu-go added a new key to output for checks and this trips up the custom properties logic. There is open issue about this with sensu-go. The new key looks to be a new property that needs to be added, |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Use Puppet 5 when provisioning Debian based vagrant boxes.
Related Issue
#901
Motivation and Context
Get vagrant boxes uses Puppet version supported by sensu2 changes as well as necessary to support Ubuntu 18.04.
How Has This Been Tested?
General
bundle exec rake validate lint spec