Fix pubsub for Sensu Redis transport #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure is due to JRuby being unable to install the very recent version of eventmachine. A JRuby build of eventmachine 1.2.1 needs to be published to Rubygems. |
|
@cwjohnston ready for review
|
|
Nice work dude
|
|
This is one piece of the #9 puzzle. We'll need a Sensu release in order to further test ElastiCache failover. |
|
jruby gem has been published, builds now passing 👍 |
|
relates to sensu/sensu-transport#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the use of
Hash.new([]), as it is one cause of Sensu client subscription issues resulting in duplicate check requests and executions.