Skip to content
This repository has been archived by the owner on Jan 1, 2020. It is now read-only.

Sensu clients using rabbitmq + TLS should verify the server certificate #1745

Closed
Fitzsimmons opened this issue Sep 20, 2017 · 1 comment
Closed

Comments

@Fitzsimmons
Copy link

Fitzsimmons commented Sep 20, 2017

Current Behavior

The AMQP client used by the sensu-client doesn't verify the server's certificate, making it trivial to carry out a man in the middle attack against the TLS connection. It defeats the purpose of using TLS if the authentication is disabled.

Expected Behavior

The AMQP client verifies the connection domain name against the server certificate's Subject Alternative Names or Common Name (although CN is now deprecated). The connection is aborted if the domain name does not match or the issuer of the server's cert is not trusted by the OS's local store or a user-configured CA.

Possible Solution

Implement the ssl_verify_peer method for the AMQP gem.

@Fitzsimmons
Copy link
Author

Yup this is a dupe, sorry

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant