This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
[API] make DELETE "/clients/#{id}" idempotent #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| $redis.hgetall('events:' + client_name).callback do |events| | ||
| events.each do |check_name, event_json| | ||
| resolve_event(event_hash(event_json, client_name, check_name)) | ||
| end |
There was a problem hiding this comment.
Any reason retrieving the events isn't rolled into the EM timer? Does resolve_event have the opportunity to throw or change the API response?
|
This is very strange, as a client key cannot exist in the clients set, unless it has be created (only done by the server, always stringified JSON). |
|
Saved: https://github.com/sensu/sensu/blob/master/lib/sensu/server.rb#L83 Order of operations looks "correct". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a solution, but related to #430. With mysteriously missing redis keys,
DELETE /clients/b33fwill not actually remove a client from the clients set, clear the history, or delete events. It seems aDELETErequest ought to be idempotent and result in a clean state with or without the existence of a client key