Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that book file whose name contains カタカナ can't be loaded #330

Closed
wants to merge 30 commits into from

Conversation

sensuikan1973
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #330 (efcc837) into main (e79911c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   96.16%   96.16%   -0.01%     
==========================================
  Files          15       15              
  Lines         626      678      +52     
==========================================
+ Hits          602      652      +50     
- Misses         24       26       +2     
Flag Coverage Δ
macos-latest 96.16% <100.00%> (+0.31%) ⬆️
ubuntu-latest 96.01% <100.00%> (+0.33%) ⬆️
unit_test 96.16% <100.00%> (-0.01%) ⬇️
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/edax_command_test.dart 99.71% <100.00%> (+0.04%) ⬆️
lib/src/ffi/dylib_utils.dart 75.00% <0.00%> (-12.50%) ⬇️
lib/src/libedax.dart 95.48% <0.00%> (-0.65%) ⬇️

@sensuikan1973 sensuikan1973 force-pushed the investigation_non_ASCII_book_path_loading branch from a45434e to 988074b Compare March 9, 2023 14:20
@sensuikan1973
Copy link
Owner Author

sensuikan1973 commented Mar 9, 2023

0010003 stdout doesn't contain "Loading book from ./resources/テスト_book.dat", but b8e491f contains "Loading book from ./resources/test_book.dat...done".

Then, fopen caused error, maybe.

https://learn.microsoft.com/ja-jp/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-170

@sensuikan1973
Copy link
Owner Author

@sensuikan1973 sensuikan1973 force-pushed the investigation_non_ASCII_book_path_loading branch from 7a11af5 to 773635f Compare March 9, 2023 15:30
@sensuikan1973
Copy link
Owner Author

@sensuikan1973 sensuikan1973 changed the title investigate into book loading of non ASCII path bug? fix bug that book file with non ASCII path can't be loaded Mar 9, 2023
@sensuikan1973
Copy link
Owner Author

@sensuikan1973 sensuikan1973 changed the title fix bug that book file with non ASCII path can't be loaded fix bug that book file whose name contains カタカナ can't be loaded Mar 11, 2023
@sensuikan1973
Copy link
Owner Author

1 similar comment
@sensuikan1973
Copy link
Owner Author

@sensuikan1973
Copy link
Owner Author

hum....

do workaround like sensuikan1973/pedax#1339

@sensuikan1973 sensuikan1973 deleted the investigation_non_ASCII_book_path_loading branch March 11, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants