Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint check failed #18

Closed
wilsonwu opened this issue Dec 7, 2022 · 3 comments · Fixed by #23
Closed

Lint check failed #18

wilsonwu opened this issue Dec 7, 2022 · 3 comments · Fixed by #23

Comments

@wilsonwu
Copy link
Contributor

wilsonwu commented Dec 7, 2022

Issue Description

Type: bug report

Describe what happened (or what feature you want)

  Running [/home/runner/golangci-lint-1.50.1-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: File is not `goimports`-ed (goimports)
  
  Error: issues found
  Ran golangci-lint in 34803ms

Describe what you expected to happen

Fix it.
@wilsonwu
Copy link
Contributor Author

wilsonwu commented Dec 7, 2022

@jnan806 could you help on this?

@jnan806
Copy link
Contributor

jnan806 commented Dec 7, 2022

Because of some code files should be re-formatted by goimports. Like following :
image

And now the golangci-lint-action looks not provide more detail logs.
I have commit an issue in the official issue list. refers to golangci/golangci-lint-action#618

@wilsonwu
Copy link
Contributor Author

wilsonwu commented Dec 7, 2022

That is good, let's keep eyes on it.

@jnan806 jnan806 mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Locate file:line in golangci-lint jnan806/sentinel-dashboard-k8s-operator
2 participants
@wilsonwu @jnan806