ci: Locate file:line in golangci-lint #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
|
lgtm, @garroshh please help to review. |
|
LGTM |
|
@sczyh30 please help to merge, thanks. |
|
@sczyh30 Yes, we are doing some enhancement for the operator, but currently this repo can't release docker image, so we can't use it directly, when the docker hub account ready, please let me know, we can move here for all. |
1 similar comment
|
@sczyh30 Yes, we are doing some enhancement for the operator, but currently this repo can't release docker image, so we can't use it directly, when the docker hub account ready, please let me know, we can move here for all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiangnan Jia jnan0806@gmail.com
What type of PR is this?
What this PR does / why we need it:
Now, the golangci-lint can not locate the file:line when lint occurs error,like following:
Which issue(s) this PR fixes:
Fixes #18
Describe how you did it:
add args according golangci/golangci-lint-action#119 (comment)