Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow on 32-bit platform #422

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Long Dai long0dai@foxmail.com

Describe what this PR does / why we need it

Fix dapr/components-contrib#1033

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2021

CLA assistant check
All committers have signed the CLA.

@daixiang0
Copy link
Contributor Author

@sczyh30 please review

@sczyh30
Copy link
Member

sczyh30 commented Jul 27, 2021

Hi, could you please reformat your code?

@daixiang0
Copy link
Contributor Author

@sczyh30 done.

@daixiang0
Copy link
Contributor Author

ping @sczyh30

@sczyh30
Copy link
Member

sczyh30 commented Jul 28, 2021

It seems that the linter check failed: https://github.com/alibaba/sentinel-golang/pull/422/checks?check_run_id=3177687857

@daixiang0 daixiang0 force-pushed the master branch 2 times, most recently from be9644b to 76e9889 Compare July 28, 2021 02:28
@daixiang0
Copy link
Contributor Author

@sczyh30 I use force covert, please review

@codecov-commenter
Copy link

Codecov Report

Merging #422 (7e4e72f) into master (a99057c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7e4e72f differs from pull request most recent head 76e9889. Consider uploading reports for the commit 76e9889 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   53.53%   53.53%   -0.01%     
==========================================
  Files          89       89              
  Lines        5792     5791       -1     
==========================================
- Hits         3101     3100       -1     
  Misses       2342     2342              
  Partials      349      349              
Impacted Files Coverage Δ
core/stat/base/leap_array.go 72.88% <100.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99057c...76e9889. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0
Copy link
Contributor Author

daixiang0 commented Jul 28, 2021

@sczyh30 thanks for the review, when is the next release? Or a bugfix version?

@sczyh30 sczyh30 merged commit 194d4be into alibaba:master Jul 28, 2021
@sczyh30
Copy link
Member

sczyh30 commented Jul 28, 2021

Thanks for contributing!

@sczyh30
Copy link
Member

sczyh30 commented Jul 28, 2021

@sczyh30 thanks for the review, when is the next release? Or a bugfix version?

Maybe next week. cc @louyuting @sanxun0325 @luckyxiaoqiang

Signed-off-by: Long Dai <long0dai@foxmail.com>
@sczyh30
Copy link
Member

sczyh30 commented Aug 16, 2021

Hi, v1.0.3 has been released: https://github.com/alibaba/sentinel-golang/releases/tag/v1.0.3

@daixiang0
Copy link
Contributor Author

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash from Sentinel issue on arm 32-bit
4 participants