-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integer overflow on 32-bit platform #422
Conversation
@sczyh30 please review |
Hi, could you please reformat your code? |
@sczyh30 done. |
ping @sczyh30 |
It seems that the linter check failed: https://github.com/alibaba/sentinel-golang/pull/422/checks?check_run_id=3177687857 |
be9644b
to
76e9889
Compare
@sczyh30 I use force covert, please review |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 53.53% 53.53% -0.01%
==========================================
Files 89 89
Lines 5792 5791 -1
==========================================
- Hits 3101 3100 -1
Misses 2342 2342
Partials 349 349
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sczyh30 thanks for the review, when is the next release? Or a bugfix version? |
Thanks for contributing! |
Maybe next week. cc @louyuting @sanxun0325 @luckyxiaoqiang |
Signed-off-by: Long Dai <long0dai@foxmail.com>
Hi, v1.0.3 has been released: https://github.com/alibaba/sentinel-golang/releases/tag/v1.0.3 |
cool! |
Signed-off-by: Long Dai long0dai@foxmail.com
Describe what this PR does / why we need it
Fix dapr/components-contrib#1033
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews