Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of nodata in export2tiff pipeline, round 2 #101

Merged

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Sep 30, 2022

ExportToTiff pipeline didn't behave as expected. When merging tiffs, I wanted to set the empty space to the no-data value, turns out there were issues because of:

  • not setting the -init param
  • not using the values as strings (- was understood as a parameter???)

Thanks @batic for the help.

@mlubej mlubej added the bug Something isn't working label Sep 30, 2022
@mlubej mlubej self-assigned this Sep 30, 2022
Copy link
Collaborator

@zigaLuksic zigaLuksic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to add a test for this?

@mlubej
Copy link
Contributor Author

mlubej commented Sep 30, 2022

is there a way to add a test for this?

One should be able to read metainfo from the raster and compare with the expected values for various combinations of parameters and parameter values.

@zigaLuksic
Copy link
Collaborator

is there a way to add a test for this?

One should be able to read metainfo from the raster and compare with the expected values for various combinations of parameters and parameter values.

are you up for it? otherwise just open an issue on the internal repo

@zigaLuksic zigaLuksic merged commit 2090fbd into develop Sep 30, 2022
@zigaLuksic zigaLuksic deleted the bug/export-maps-pipeline-false-setting-of-nodata branch September 30, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants