Hardcode the compression when saving #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigaLuksic
force-pushed
the
feat/hardcode-compression
branch
from
217f256
to
61159c0
Compare
|
I thought the idea was to convert the parameter to a boolean one, which is True (to use compression 1) by default, otherwise the user can specify they are not interested in compression, since they want to prioritize speed and not disk space. Would that still make sense, or is it too similar to the situation before? |
The idea was to get rid of a parameter, because we often have a lot of parameters we never touch |
|
not doing it (for now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter never set to anything other than 1 except by mistake.
With this we get rid of some code complexity and inconsistency.
But i'm not entirely sure if this is a step in the right direction :/