Update check_query_length(), Unicode support #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 3 3
Lines 555 555
Branches 118 118
=======================================
Hits 531 531
Misses 15 15
Partials 9 9
Continue to review full report at Codecov.
|
"~" is no longer URL-encoded in Python 3.7
DHUS expects non-ASCII characters to be encoded in latin-1. Added proper Unicode support by explicitly setting our encoding to UTF-8 in the request header. Added a unit test for this as well, but VCR.py does not properly support Unicode characters in request bodies, so I disabled this for now.
valgur
force-pushed
the
check-query-length
branch
from
a8cc642
to
5c6c127
Compare
valgur
changed the title
|
I also added Unicode support for search queries. The server parses query strings as Latin-1 by default, but can be made to accept UTF-8 by setting a specific header. |
|
The unit test for Unicode support is currently disabled due to a VCR.py bug. The test can be enabled again once kevin1024/vcrpy#386 gets pulled and included in a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server-side query string handling has changed a bit so we need to update the calculation logic in
check_query_length(). Related to #228.