fix(cli): typecheck before bundle (#891)

sentioxyz · Jul 16, 2024 · c95e38e · c95e38e
1 parent 3120ca8
commit c95e38e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -14,7 +14,7 @@
     "!{lib,src}/**/*.test.{js,ts}"
   ],
   "scripts": {
-    "build": "pnpm bundle",
+    "build": "pnpm tsc --noEmit && pnpm bundle",
     "postbuild": "pnpm install",
     "bundle": "esbuild --platform=node --format=esm --bundle src/index.ts --outfile=lib/index.js --sourcemap --inject:src/cjs-shim.ts --external:@sentio/sdk",
     "cli": "tsx src/index.ts",

diff --git a/packages/cli/src/abi.ts b/packages/cli/src/abi.ts
@@ -133,7 +133,7 @@ export async function getABI(
   }
 }
 
-export function getABIFilePath(chain: string, name: string, address: string): string {
+export function getABIFilePath(chain: string, name: string, address?: string): string {
   let subpath
   let filename = name ?? address
   switch (chain) {

diff --git a/packages/runtime/package.json b/packages/runtime/package.json
@@ -15,7 +15,7 @@
     "!{lib,src}/tests"
   ],
   "scripts": {
-    "build": "pnpm bundle",
+    "build": "pnpm tsc --noEmit && pnpm bundle",
     "build:all": "pnpm --filter=$(node -p \"require('./package.json').name\")... build",
     "bundle": "tsup --config src/tsup.config.ts",
     "compile": "tsc",