Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP Password field is wrong type. #208

Closed
ghost opened this issue Nov 20, 2015 · 4 comments
Closed

SMTP Password field is wrong type. #208

ghost opened this issue Nov 20, 2015 · 4 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Nov 20, 2015

SMTP Pass field is textarea instead of input with password type.

Change:

<textarea cols="30" rows="1" name="smtp_password"></textarea>

To:

<input type="password" name="smtp_password" placeholder="Type your smtp password here">
@TGates71
Copy link
Member

Unfortunately, due to the way it is coded and the way it renders the input lines from the database, it cannot be changed in the manner you describe. Will look into it some more.

@TGates71
Copy link
Member

In this file: https://github.com/sentora/sentora-core/blob/master/modules/sentoraconfig/code/controller.ext.php
Between line 51 and 52 add:

                if (strpos(ctrl_options::OutputSettingTextArea($rowsettings['so_name_vc']),'smtp_password') !== false) {
                    $fieldhtml = '<input type="password" name="smtp_password" value="'.$rowsettings['so_value_tx'].'">';
                }

It should look like this when done:

                }
                if (strpos(ctrl_options::OutputSettingTextArea($rowsettings['so_name_vc']),'smtp_password') !== false) {
                    $fieldhtml = '<input type="password" name="smtp_password" value="'.$rowsettings['so_value_tx'].'">';
                }
                array_push($res, array('cleanname' => ui_language::translate($rowsettings['so_cleanname_vc']),

Give it a test.
Update pushed to master: https://github.com/sentora/sentora-core/blob/master/modules/sentoraconfig/code/controller.ext.php

@MBlagui MBlagui added the bug label Apr 11, 2016
@MBlagui MBlagui added this to the 1.0.5 milestone Apr 11, 2016
@Dukecitysolutions
Copy link
Contributor

@TGates71 , @MBlagui ,
Any updates on this?

@TGates71
Copy link
Member

Was completed 9 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants