fix: change log function to work with set -euo pipefail #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set -euo pipefail is used in a script, the script exits when there is a failure. There are side effects that one needs to be aware of like mentioned here https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425?permalink_comment_id=4326440#gistcomment-4326440. The log function in the script checks for "[ "${lvl,,}" == error ]" and uses && operator to exit. However when the condition check does not succeed, this gets treated as error and the script exits. The fix is to use if check here which does not cause set -e to trigger exit.
|
@vmarora Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set -euo pipefail is used in a script, the script exits when there is a failure. There are side effects that one needs to be aware of like mentioned here https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425?permalink_comment_id=4326440#gistcomment-4326440. The log function in the script checks for "[ "${lvl,,}" == error ]" and uses && operator to exit. However when the condition check does not succeed, this gets treated as error and the script exits. The fix is to use if check here which does not cause set -e to trigger exit.