Handle non printable characters in region names #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling regions names with non printable characters caused Hannibal to print question marks and not route to correct region details. This fixes sentric#20.
meniku
pushed a commit
that referenced
this pull request
Jul 15, 2013
|
I also modified the Javascript-Code to use the regionURI. However, I wonder whether it wouldn't be better if we just use the regionID-part of the regionName in our URI? |
|
@meniku I think this URI-handling part deserves a tight refactoring and I agree regionID-part is a great candidate. I think all theses
For the moment I just wanted to keep it as close as possible from the original one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling regions names with non printable characters caused Hannibal
to print question marks and not route to correct region details.
This fixes #20.