Improve Snuba config #135
Merged
Improve Snuba config #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mokto
reviewed
Jul 28, 2020
| REDIS_HOST = {{ include "sentry.redis.host" . | quote }} | ||
| REDIS_PORT = {{ include "sentry.redis.port" . }} | ||
| {{- if $redisPass }} | ||
| REDIS_PASSWORD = {{ $redisPass | quote }} | ||
| {{- end }} | ||
| REDIS_DB = int(env("REDIS_DB", 1)) | ||
| USE_REDIS_CLUSTER = False |
There was a problem hiding this comment.
You removed this and both DOGSTATSD, I just want to make sure it's on purpose?
There was a problem hiding this comment.
Yes, we should now be able to inherit the values from the default settings.py
Mokto
approved these changes
Jul 29, 2020
yoan-adfinis
reviewed
Aug 7, 2020
|
@Mokto Hey just wondering if you wanted me to merge this or if something's blocking? |
|
Go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Snuba config in-order to reduce the maintanance required to support future versions of Snuba.