Merge pull request #204 from sentrysoftware/124-incorrect-connectors-…

…shouldnt-lead-to-an-engine-failure

Issue #124: Invalid connector no longer results in an empty Connector…

metricshub-engine/src/main/java/org/sentrysoftware/metricshub/engine/connector/parser/ConnectorLibraryParser.java

@@ -46,6 +46,8 @@
 @Slf4j
 public class ConnectorLibraryParser {
 
+	public static final String CONNECTOR_PARSING_ERROR = "Error while parsing connector {}: {}";
+
 	/**
 	 * The ObjectMapper instance for handling YAML files.
 	 */
@@ -82,8 +84,13 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO
 			}
 			final ConnectorParser connectorParser = ConnectorParser.withNodeProcessorAndUpdateChain(file.getParent());
 
-			final Connector connector = connectorParser.parse(file.toFile());
-			connectorsMap.put(filename.substring(0, filename.lastIndexOf('.')), connector);
+			try {
+				final Connector connector = connectorParser.parse(file.toFile());
+				connectorsMap.put(filename.substring(0, filename.lastIndexOf('.')), connector);
+			} catch (Exception e) {
+				log.error(CONNECTOR_PARSING_ERROR, filename, e.getMessage());
+				log.debug("Exception: ", e);
+			}
 
 			return FileVisitResult.CONTINUE;
 		}
@@ -127,10 +134,11 @@ public FileVisitResult visitFile(Path path, BasicFileAttributes attrs) throws IO
 									final Connector connector;
 									try {
 										connector = connectorParser.parse(Files.newInputStream(path), connectorFolderUri, fileName);
-									} catch (IOException e) {
-										throw new IllegalStateException(e);
+										connectorsMap.put(fileName.substring(0, fileName.lastIndexOf('.')), connector);
+									} catch (Exception e) {
+										log.error(CONNECTOR_PARSING_ERROR, fileName, e.getMessage());
+										log.debug("Exception: ", e);
 									}
-									connectorsMap.put(fileName.substring(0, fileName.lastIndexOf('.')), connector);
 								}
 							);