Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discarded connector_id when connector implements simple strategies #87

Closed
NassimBtk opened this issue Mar 6, 2024 · 0 comments · Fixed by #88
Closed

Fix discarded connector_id when connector implements simple strategies #87

NassimBtk opened this issue Mar 6, 2024 · 0 comments · Fixed by #88
Assignees
@NassimBtk @alexdgilbert
Labels
bug Something isn't working java

Comments

@NassimBtk
Copy link
Member

Description

The issue occurs within the MonitorFactory, where it resets attributes in subsequent job cycles, causing the removal of the connector_id attribute. As a result, critical metadata like metric descriptions, units, and types are omitted when metric values are being recorded for transmission to the OTLP Receiver.

Resolution

To resolve this issue, ensure the connector_id is maintained across job cycles.
@NassimBtk NassimBtk added the java label Mar 6, 2024
NassimBtk added a commit that referenced this issue Mar 6, 2024
@NassimBtk
Issue #87: Fix discarded connector_id when connector implements simple
634abab 
* Now the `connector_id` is maintained across job cycles.
NassimBtk added a commit that referenced this issue Mar 6, 2024
@NassimBtk
Issue #87: Fix discarded connector_id when connector implements simple
dae0b88 
* Now the `connector_id` is maintained across job cycles.
@NassimBtk NassimBtk linked a pull request Mar 6, 2024 that will close this issue
Issue #87: Fix discarded connector_id when connector implements simple #88
Merged
NassimBtk added a commit that referenced this issue Mar 6, 2024
@NassimBtk
Merge pull request #88 from sentrysoftware/feature/issue-87-fix-disca…
c5d492e 
…rded-connector_id-when-connector-implements-simple-strategies

Issue #87: Fix discarded `connector_id` when connector implements simple
@NassimBtk NassimBtk added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NassimBtk NassimBtk

@alexdgilbert alexdgilbert

Labels
bug Something isn't working java
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #87: Fix discarded connector_id when connector implements simple sentrysoftware/metricshub
2 participants
@NassimBtk @alexdgilbert