Issue #139: Add a sleep input to executeForEachEntryOf #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility to wait between each request of an executeForEachEntryOf source
TNohaic
requested review from
MedMaalej,
NassimBtk,
MarcDouguedroit,
bertysentry,
NathalieLe,
alexdgilbert and
CherfaElyes
NassimBtk
requested changes
Mar 28, 2024
| ) { | ||
| this.source = source; | ||
| this.concatMethod = concatMethod == null ? EntryConcatMethod.LIST : concatMethod; | ||
| this.sleep = sleep == null ? 0 : sleep; |
There was a problem hiding this comment.
Change to this.sleep = sleep;
| try { | ||
| Thread.sleep(sleep); | ||
| } catch (InterruptedException e) { | ||
| log.error("threadSleep", "Thread interrupted during sleep between two requests."); |
There was a problem hiding this comment.
log.error("Hostname {} - Thread interrupted during sleep between two 'execute for each entry' requests.", hostname);
| * The sleep integer in ms. | ||
| */ | ||
| @JsonSetter(nulls = SKIP) | ||
| private Integer sleep; |
There was a problem hiding this comment.
Deserialize with PositiveIntegerDeserializer
| @@ -505,6 +507,14 @@ private SourceTable processExecuteForEachEntryOf(final Source source, final Stri | |||
| copy.update(value -> replaceSourceReference(value, copy)); | |||
|
|
|||
| concatEntryResult(source, result, row, copy.accept(sourceProcessor)); | |||
| if (sleep != null && sleep > 0) { | |||
…-a-sleep-input-to-executeforeachentryof
Correction after PR review
NassimBtk
approved these changes
Mar 29, 2024
NassimBtk
deleted the
feature/issue-139-add-a-sleep-input-to-executeforeachentryof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to wait between each request of an executeForEachEntryOf source