Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #169: Factorize SNMP business logic into common maven module #177

Merged
merged 29 commits into from
May 20, 2024
Merged

Issue #169: Factorize SNMP business logic into common maven module #177

merged 29 commits into from
May 20, 2024

Conversation

SafaeAJ
Copy link
Contributor

@SafaeAJ SafaeAJ commented May 17, 2024 •
edited
Loading

  • Created SnmpV3Extension.
  • Created SnmpV3Configuration.
  • Updeted SnmpConfiguration.
  • Updeted SnmpExtension.
  • Update SnmpConfigCli
  • Added unit tests (SnmpGetCriterionProcessor, SnmpGetNextCriterionProcessor, SnmpGetSourceProcessor, SnmpTableSourceProcessor).
  • Updated agent CLI.
  • Created new Maven module, metricshub-snmp-extension-common for refactoring.
  • Tested the SNMPV3 protocol using the engine and the agent.
  • Updated pom.xml.
  • Added an example of SNMP v3 configuration in configure-agent and at CLI doc.
  • Reduced JaCoCo coverage in Metricshub SNMPV3 Project.

@SafaeAJ SafaeAJ linked an issue May 17, 2024 that may be closed by this pull request
Factorize SNMP Business Logic into Common Maven Module #169
Closed
@SafaeAJ SafaeAJ requested a review from NassimBtk May 17, 2024 13:04
@SafaeAJ SafaeAJ changed the base branch from main to feature/EPIC-extension-system May 17, 2024 13:39
@NassimBtk NassimBtk changed the title Feature/issue 169 factorize snmp business logic into common maven module Issue #169: Factorize SNMP business logic into common maven module May 17, 2024
Base automatically changed from feature/EPIC-extension-system to main May 17, 2024 15:21
@SafaeAJ
Issue #169: Factorize SNMP business logic into common maven module
13a32af 
          * [Created SnmpV3Extension.]
          * [Created SnmpV3Configuration]
          * [Tested the SNMPV3 protocol using the engine and the agent.]
          * [Added unit tests (SnmpGetCriterionProcessor, SnmpGetNextCriterionProcessor, SnmpGetSourceProcessor, SnmpTableSourceProcessor)]
          * [Created new Maven module, metricshub-snmp-extension-common for refactoring.]
          * [Updeted SnmpExtension.]
          * [Added an example of SNMP v3 configuration in configure-agent and at CLI doc.]
@SafaeAJ
fix snmpV3ConfigCli
4b4dd3b
NassimBtk
NassimBtk requested changes May 20, 2024
View reviewed changes
Copy link
Member

@NassimBtk NassimBtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails on linux, please make sure the coverage ratio is expected in both windows and linux builds.

metricshub-doc/src/site/markdown/configuration/configure-agent.md Outdated Show resolved Hide resolved
metricshub-agent/pom.xml Outdated Show resolved Hide resolved
...-agent/src/main/java/org/sentrysoftware/metricshub/cli/service/protocol/SnmpV3ConfigCli.java Outdated Show resolved Hide resolved
...-agent/src/main/java/org/sentrysoftware/metricshub/cli/service/protocol/SnmpV3ConfigCli.java Outdated Show resolved Hide resolved
...-agent/src/main/java/org/sentrysoftware/metricshub/cli/service/protocol/SnmpV3ConfigCli.java Show resolved Hide resolved
...sion/src/main/java/org/sentrysoftware/metricshub/extension/snmpv3/SnmpV3RequestExecutor.java Outdated Show resolved Hide resolved
...sion/src/main/java/org/sentrysoftware/metricshub/extension/snmpv3/SnmpV3RequestExecutor.java Outdated Show resolved Hide resolved
...-extension/src/main/java/org/sentrysoftware/metricshub/extension/snmpv3/SnmpV3Extension.java Outdated Show resolved Hide resolved
metricshub-windows/pom.xml.orig Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@SafaeAJ
Issue #169: Factorized SNMP business logic into common Maven module
e81d98a 
Deleted unused dependencies in the pom.xml of the metricshub agent and in the pom.xml of metricshub SNMP version 3

Fixed Java comments in the metricshub SNMP version 3

Changed the implementation of the method interpretValueOf in the SnmpV3Configuration class
@SafaeAJ
Issue #169: Factorized SNMP business logic into a common Maven module.
42438bf 
Added AuthTypeDeserializer class and PrivacyDeserializer class to Metricshub SNMPv3.

Fixed formatting in the documentation of Metricshub SNMPv3.

Deleted unused XML files in Metricshub Linux.
@SafaeAJ
Issue #169: Factorized SNMP business logic into a common Maven module.
afe9c6d 
Fixed formatting in the documentation of Metricshub SNMPv3.
@SafaeAJ
Issue #169: Factorized SNMP business logic into a common Maven module.
e54a9e7 
Fixed test coverage ratio in Metricshub agent.
@SafaeAJ
Issue #169: Factorized SNMP business logic into a common Maven module.
f58cb27 
Fixed pom.xml of metricshub linux and deleted unused xml file from metricshub snmp extension common.
@SafaeAJ
Issue #169: Factorized SNMP business logic into a common Maven module.
271193c 
Fixed metricshub doc snmpv3
@NassimBtk NassimBtk merged commit 826a29b into main May 20, 2024
2 checks passed
@NassimBtk NassimBtk deleted the feature/issue-169-factorize-snmp-business-logic-into-common-maven-module branch May 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NassimBtk NassimBtk NassimBtk approved these changes

@CherfaElyes CherfaElyes Awaiting requested review from CherfaElyes

@MedMaalej MedMaalej Awaiting requested review from MedMaalej

@bertysentry bertysentry Awaiting requested review from bertysentry

@TNohaic TNohaic Awaiting requested review from TNohaic

@alexdgilbert alexdgilbert Awaiting requested review from alexdgilbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Factorize SNMP Business Logic into Common Maven Module
2 participants
@SafaeAJ @NassimBtk