Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #241: missing skip null annotation on port field leads to configuration issues #245

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Issue #241: missing skip null annotation on port field leads to configuration issues #245

merged 3 commits into from
Jun 10, 2024

Conversation

CherfaElyes
Copy link
Contributor

  • Added skip null annotation on Wbem port, protocol and timeout
  • Added skip null annotation on WinRm port and timeout
  • Replaced all @Builder.Default annotations with @default in the different protocol extension configurations.
  • Tested all the changes on MetricsHub agent

@CherfaElyes
Issue #241: Missing Skip Null Annotation on Port Field Leads to Confi…
920df9f 
…guration Issues

* Added skip null annotation
@CherfaElyes
Issue #241: Missing Skip Null Annotation on Port Field Leads to Confi…
2d4045d 
…guration Issues

* Added skip null annotation on Wbem port, protocol and timeout
* Added skip null annotation on WinRm port and timeout
* Replaced all @Builder.Default annotations with @default in the different protocol extension configurations.
* Tested all the changes on MetricsHub agent
@CherfaElyes CherfaElyes self-assigned this Jun 10, 2024
@CherfaElyes CherfaElyes linked an issue Jun 10, 2024 that may be closed by this pull request
Missing Skip Null Annotation on Port Field Leads to Configuration Issues #241
Closed
@CherfaElyes
Merge branch 'main' into feature/issue-241-missing-skip-null-annotati…
5a8b2e3 
…on-on-port-field-leads-to-configuration-issues
@NassimBtk NassimBtk self-requested a review June 10, 2024 12:50
@NassimBtk NassimBtk merged commit ab152e3 into main Jun 10, 2024
2 checks passed
@NassimBtk NassimBtk deleted the feature/issue-241-missing-skip-null-annotation-on-port-field-leads-to-configuration-issues branch June 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NassimBtk NassimBtk NassimBtk approved these changes

Assignees

@CherfaElyes CherfaElyes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Skip Null Annotation on Port Field Leads to Configuration Issues
2 participants
@CherfaElyes @NassimBtk