-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #89: Reviewed configure-agent.md #91
Merged
NassimBtk
merged 5 commits into
main
from
feature/issue-89-doc-review-needed-for-configure-agentmd
Mar 8, 2024
Merged
Issue #89: Reviewed configure-agent.md #91
NassimBtk
merged 5 commits into
main
from
feature/issue-89-doc-review-needed-for-configure-agentmd
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iguitton
commented
Mar 7, 2024
- reviewed the entire file
- restructured the file
- rephrased sections for better clarity
- updated the quick start page to be consistent with the updated version of configure-agent.md
* reviewed the entire file * restructured the file * rephrased sections for better clarity * updated the quick start page to be consistent with the updated version of configure-agent.md
@NassimBtk , this branch should be merged after #90 |
* Fixed a broken link
Closed
NassimBtk
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates, conflict resolution and we should be good.
metricshub-doc/src/site/markdown/configuration/configure-agent.md
Outdated
Show resolved
Hide resolved
metricshub-doc/src/site/markdown/configuration/configure-agent.md
Outdated
Show resolved
Hide resolved
* Took Nassim's comments into account
Thanks @NassimBtk for your feedback. I took your comments into account. Please re-review :) |
NassimBtk
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.