Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Fix (wandb_writer): correct spelling mistake #119

Merged
merged 1 commit into from Jan 3, 2022
Merged

Conversation

lorr1
Copy link
Collaborator

@lorr1 lorr1 commented Jan 3, 2022

Writer_config was misspelled as write_config to get the group for wandb.

Writer_config was misspelled as write_config to get the group for wandb.
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #119 (daa4d7d) into master (804a40f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          40       40           
  Lines        2024     2024           
  Branches      456      456           
=======================================
  Hits         1865     1865           
  Misses         94       94           
  Partials       65       65           
Flag Coverage Δ
unittests 92.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/emmental/logging/wandb_writer.py 69.23% <ø> (ø)

@senwu senwu merged commit 040ff13 into master Jan 3, 2022
@senwu
Copy link
Owner

senwu commented Jan 3, 2022

Nice catch up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants