Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LINEARFIT SPLINELINEARFIT AKIMASPLINEFIT #1

Merged
merged 32 commits into from
Oct 11, 2023
Merged

Conversation

pi-r-p
Copy link
Collaborator

@pi-r-p pi-r-p commented Sep 9, 2022

No description provided.

@randomboolean
Copy link
Collaborator

  • The naming has to be revised since Akima and spline interpolators are not linear interpolators.
  • I believe it is a better idea to separate the fit (obtaining function parameters) and the creation of the function in two speerate functions, in the same manner it is done in the main library with POLYFIT and POLYFUNC
  • This pose the question of the naming convention given to functions of this extension, since for now, BICUBICFIT, TRICUBICFIT and MICROSPHEREFIT outputs directly a function, unlike POLYFIT.
  • Also, POLYFIT and POLYFUNC are 1-d interpolators on the ticks, so maybe we would have to name the functions of this PR something like: VALUEPOLYFIT, VALUEPOLYFUNC, VALUESPLINEFIT, VALUESPLINEFUNC, VALUEAKIMAFIT, VALUEAKIMAFUNC

@pi-r-p
Copy link
Collaborator Author

pi-r-p commented Sep 13, 2022

I will update readme and doc once we converge.
For the moment, I did not created the "FIT" function for snapshot 1D interpolator, I clone the input list.

Imho, FIT is a perfect name for regression, not for an interpolator.

@randomboolean randomboolean merged commit e066442 into master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants