Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint configuration not included in git repo #2

Closed
damoclark opened this issue Aug 6, 2017 · 3 comments
Closed

eslint configuration not included in git repo #2

damoclark opened this issue Aug 6, 2017 · 3 comments

Comments

@damoclark
Copy link
Contributor

Hi Pablo,

I've opened a git clone of your code and while eslint is included in your dev toolchain, you haven't committed your eslint config to the repo.

If you could do this, then I can ensure any PR I issue will be properly formatted. :)

Damien.

@pablodgonzalez
Copy link
Member

Hi @damoclark, Thanks for the pull requests.
We are using the defaults values of eslint, nevertheless is a good idea freeze the config in the repo.
plese give a few days to review the PRs.
Thanks! Good Work!

@damoclark
Copy link
Contributor Author

Hey @pablodgonzalez,

No problem. Thanks for sharing your library.

I'm adding features that I need for my use case, but it may not align with your future intentions. If anything in my PRs is contrary to your long term intent for cec-monitor, let me know. Happy to adapt accordingly.

Cheers,
Damo.

@pablodgonzalez
Copy link
Member

@damoclark I've committed the eslint config.
I'm go to seeing your PR today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants