Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Commit dialog #78

Merged
merged 29 commits into from Nov 24, 2018
Merged

Commit dialog #78

merged 29 commits into from Nov 24, 2018

Conversation

seokju-na
Copy link
Owner

@seokju-na seokju-na commented Nov 19, 2018

Checklist

  • Refactor vcs item list manager to be inject from factory
  • Add menu ui
  • Add select menu
  • Add github accounts dialog
  • Add vcs commit dialog

because it uses electron provided menu
For previous spec, it was not possible to reuse VcsItemListManager
because it only operates on one DOM container.

This commit changes the DI method to factory so that VcsItemListManager
can be created from each DOM container.
@seokju-na seokju-na self-assigned this Nov 19, 2018
@seokju-na seokju-na added this to the v1.0.0 milestone Nov 19, 2018
@seokju-na seokju-na merged commit 5d4db1d into master Nov 24, 2018
@seokju-na seokju-na mentioned this pull request Nov 26, 2018
12 tasks
@seokju-na seokju-na deleted the commit-dialog branch December 31, 2018 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant