allow failed jobs that are very long to display on the qless ui prope…

…rly. I removed the ellipses and instead allow the column to expand to the longest errored job
seomoz · Dec 6, 2012 · 6f6d510 · 6f6d510
1 parent 6f0a6a0
commit 6f6d510
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 12 deletions.
diff --git a/lib/qless/server/static/css/docs.css b/lib/qless/server/static/css/docs.css
@@ -817,3 +817,20 @@ form.well {
   }
 
 }
+
+/* For proper failed job display*/
+.l-sidebyside {
+  overflow:auto;
+}
+.l-sidebyside > * {
+  display:inline-block;
+  *display: inline;
+  *zoom: 1;
+}
+.failed-job > .min-col-size {
+  min-width: 395px;
+}
+.failed-job .row {
+  margin-left:0;
+  margin-right:10px;
+}
diff --git a/lib/qless/server/views/overview.erb b/lib/qless/server/views/overview.erb
@@ -18,7 +18,7 @@
         <%= queue['waiting']   %> /
         <%= queue['scheduled'] %> /
         <%= queue['stalled']   %> /
-        <%= queue['depends']   %> / 
+        <%= queue['depends']   %> /
         <%= queue['recurring'] %> <small>(running / waiting / scheduled / stalled / depends / recurring)</small>
       </h3>
     </div>
@@ -34,18 +34,24 @@
   <div class="page-header">
     <h1>Failed Jobs <small>D'oh!</small></h1>
   </div>
-  <% failed.sort_by { |t, count| -count }.each do |t, count| %>
-  <div class="row">
-    <div class="span4">
-      <h3 style="text-overflow: ellipsis; white-space: nowrap; overflow: hidden"><a href="<%= u "/failed/#{t}" %>"><%= t %></a></h3>
-    </div>
-    <div class="span8">
-      <h3>| <%= count %> <small>Jobs</small></h3>
-    </div>
+  <div>
+    <div class="l-sidebyside failed-job">
+      <div class="min-col-size">
+        <% failed.sort_by { |t, count| -count }.each do |t, count| %>
+        <div class="row">
+          <h3><a href="<%= u "/failed/#{t}" %>"><%= t %></a></h3>
+        </div>
+        <% end %>
+      </div>
+      <div>
+      <% failed.sort_by { |t, count| -count }.each do |t, count| %>
+        <div class="row">
+          <h3>| <%= count %> <small>Jobs</small></h3>
+        </div>
+      <% end %>
+      </div>
+    <% end %>
   </div>
-  <% end %>
-<% end %>
-
 <% if tracked['jobs'].empty? %>
   <div class="page-header">
     <h1>No Tracked Jobs <small>These aren't the droids you're looking for</small></h1>