Add key.delete() #27
Merged
Add key.delete() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadim-ex
force-pushed
the
vadim/add-delete-key
branch
from
ee2094a
to
b14a914
Compare
| def func(): | ||
| '''The bit that we want to retry''' | ||
| key.delete(headers=headers) | ||
| return True |
There was a problem hiding this comment.
The other variants don't seem to return True?
There was a problem hiding this comment.
I don't think they need to return anything (as long as they raise an exception on failure)
|
Done with first pass |
vadim-ex
force-pushed
the
vadim/add-delete-key
branch
from
b14a914
to
57e7429
Compare
|
PTAL |
|
Aside from the lingering question about |
vadim-ex
force-pushed
the
vadim/add-delete-key
branch
from
57e7429
to
975ab4b
Compare
vadim-ex
force-pushed
the
vadim/add-delete-key
branch
from
975ab4b
to
8a94857
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.