NOT FOR MERGE TUBO-5767 upgrade boto #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5a43971.
|
I think we should just upgrade whole hog. I don't want to have two dependencies. |
|
This can be closed, or it can stay open until the new PR is created. |
Merged
|
Closing in favor of #33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I started replacing all usage of Boto with Boto3. The Boto3 docs have an upgrade guide, (http://boto3.readthedocs.io/en/latest/guide/migrations3.html#creating-the-connection) but we aren't using Boto the way they show in the examples. It seemed like more work than necessary to figure out how to upgrade each usage of Boto throughout the codebase. Boto and Boto3 can both be used in the same codebase, so I decided to revert my original start and narrow down to where the connection error is coming from. We could update the usage of Boto for just that section of code.