Only add network aliases for the default network

seowalex · Jan 2, 2024 · c0ee8e6 · c0ee8e6
1 parent 693134b
commit c0ee8e6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,17 +5,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.2.1] - 2024-01-02
 
-### Changed
+### Fixed
 
-- Upgrade dependencies
+- Only add network aliases for the default network.
 
 ## [0.2.0] - 2023-08-05
 
 ### Changed
 
-- Upgrade dependencies
+- Upgrade dependencies.
 
 ### Fixed
 

diff --git a/Cargo.toml b/Cargo.toml
@@ -55,5 +55,6 @@ enum_variant_names = "allow"
 large_enum_variant = "allow"
 needless_pass_by_value = "allow"
 struct_excessive_bools = "allow"
+struct_field_names = "allow"
 too_many_lines = "allow"
 unnecessary_wraps = "allow"
diff --git a/src/commands/create.rs b/src/commands/create.rs
@@ -446,8 +446,6 @@ async fn create_containers(
                                                 project_name,
                                                 "--name",
                                                 &container_name,
-                                                "--network-alias",
-                                                service_name,
                                             ])
                                             .chain(requirements.iter().flat_map(|requirement| {
                                                 ["--requires", requirement]
@@ -470,6 +468,11 @@ async fn create_containers(
                                                     .iter()
                                                     .flat_map(|network| ["--network", network]),
                                             )
+                                            .chain(if service.networks.contains_key("default") {
+                                                vec!["--network-alias", service_name]
+                                            } else {
+                                                vec![]
+                                            })
                                             .chain(volumes.iter().map(AsRef::as_ref))
                                             .chain(
                                                 secrets

diff --git a/src/commands/run.rs b/src/commands/run.rs
@@ -201,8 +201,6 @@ async fn run_container(
                     project_name,
                     "--name",
                     &container_name,
-                    "--network-alias",
-                    &args.service,
                 ])
                 .chain(
                     requirements
@@ -216,6 +214,11 @@ async fn run_container(
                     vec![]
                 })
                 .chain(networks.iter().flat_map(|network| ["--network", network]))
+                .chain(if service.networks.contains_key("default") {
+                    vec!["--network-alias", &args.service]
+                } else {
+                    vec![]
+                })
                 .chain(volumes.iter().map(AsRef::as_ref))
                 .chain(secrets.iter().flat_map(|secret| ["--secret", secret]))
                 .chain(if args.detach {