Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits #177

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Minor edits #177

merged 2 commits into from
Sep 3, 2021

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • CHANGELOG.md updated
  • README.md updated

Any other comments?

@sepandhaghighi sepandhaghighi added this to the art 5.4 milestone Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #177 (9fb8938) into dev (ba26f90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #177   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files           1        1           
  Lines         276      276           
  Branches       75       75           
=======================================
  Hits          251      251           
  Misses         23       23           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba26f90...9fb8938. Read the comment docs.

@@ -25,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- `fantasy` font renamed to `fantasy1`
- `upside_down` font renamed to `upside_down1`
- `sep` parameter added to `text2art`, `tprint`, `tsave` and `set_default` functions
- Default line separator changed from `\r\n` to `\n`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't better if we add this line into [Unreleased] section?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't better if we add this line into [Unreleased] section?

It's something related to previous version

@sadrasabouri sadrasabouri merged commit 1693570 into dev Sep 3, 2021
@sadrasabouri sadrasabouri deleted the minor_edits branch September 3, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants