Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support color names in save_html #146

Closed
sepandhaghighi opened this issue Jan 22, 2019 · 3 comments
Closed

Support color names in save_html #146

sepandhaghighi opened this issue Jan 22, 2019 · 3 comments
Assignees
@sepandhaghighi @alirezazolanvari
Labels
enhancement New feature or request
Milestone
PYCM 1.9

Comments

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Jan 22, 2019 •
edited

Support color names in save_html method :

  1. Silver
  2. Gray
  3. Red
  4. Maroon
  5. Yellow
  6. Olive
  7. Lime
  8. Green
  9. Aqua
  10. Teal
  11. Blue
  12. Navy
  13. Fuchsia
  14. Purple

And other X11 colors
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Jan 22, 2019
@sepandhaghighi sepandhaghighi self-assigned this Jan 22, 2019
sepandhaghighi added a commit that referenced this issue Jan 24, 2019
@sepandhaghighi
feat : TABLE_COLOR added #146
5b6065b
sepandhaghighi added a commit that referenced this issue Jan 24, 2019
@sepandhaghighi
fix : color_check updated for color name #146
a1fe1c1
@sepandhaghighi
Copy link
Owner Author

@alirezazolanvari please update TABLE_COLOR dictionary in pycm_param.py with X11 color names.
https://en.wikipedia.org/wiki/Web_colors

@alirezazolanvari
Copy link
Collaborator

Hi @sepandhaghighi
Is there any other work I can do on this issue?

@sepandhaghighi
Copy link
Owner Author

sepandhaghighi commented Feb 1, 2019 •
edited

Hi @sepandhaghighi
Is there any other work I can do on this issue?

Hi @alirezazolanvari
Yes, please update TABLE_COLOR dictionary with X11 standard table (I only added 14 colors).

Note : color names should be lowercase (example : mediumseagreen)

alirezazolanvari added a commit that referenced this issue Feb 1, 2019
@alirezazolanvari
update table color with X11 colors #146
7c45798
@sepandhaghighi sepandhaghighi added this to the PYCM 1.9 milestone Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sepandhaghighi sepandhaghighi

@alirezazolanvari alirezazolanvari

Labels
enhancement New feature or request
Projects
None yet
Milestone
PYCM 1.9
Development

No branches or pull requests
2 participants
@sepandhaghighi @alirezazolanvari