Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __version__ #241

Closed
sepandhaghighi opened this issue Aug 6, 2019 · 3 comments
Closed

Add __version__ #241

sepandhaghighi opened this issue Aug 6, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Aug 6, 2019

Description

Add __version__ attribute

Steps/Code to Reproduce

>>> pycm.__version__

Expected Behavior

"2.4"

Actual Behavior

Traceback (most recent call last):
File "<pyshell#1>", line 1, in <module>
pycm.__version__
AttributeError: module 'pycm' has no attribute '__version__'

Operating System

Windows 10

Python Version

Python 3.6

PyCM Version

2.4

@sepandhaghighi
Copy link
Owner Author

sepandhaghighi commented Aug 6, 2019

@sadrasabouri Hi
Would you please handle this issue?
It's simple, but consider we have a VERSION variable in pycm_param.py if you want to replace it (recommended) you should replace it wherever it's used.

And also you should :

  1. Update version_check.py in Otherfiles folder
  2. Add a tips to PyCM Version section of ISSUE_TEMPLATE.md file in .github folder

@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Aug 6, 2019
@sadrasabouri
Copy link
Collaborator

OK
I will do that for you.

sepandhaghighi added a commit that referenced this issue Aug 7, 2019
@sepandhaghighi sepandhaghighi added this to the PYCM 2.5 milestone Aug 10, 2019
@sepandhaghighi
Copy link
Owner Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants