Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #167

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Test #167

merged 2 commits into from
Nov 28, 2022

Conversation

sadrasabouri
Copy link
Collaborator

After #164 we should change the status such that it could reflect the correct upload process for all uploaded objects. While #164 has been merged, it was comparing a dictionary to False which was always true (no matter if the files uploaded correctly or not).

This PR will solve that issue.

@sadrasabouri sadrasabouri added the bug Something isn't working label Nov 28, 2022
@sadrasabouri sadrasabouri added this to the samila v1.0 milestone Nov 28, 2022
@sadrasabouri sadrasabouri self-assigned this Nov 28, 2022
test/nft_upload_test.py Outdated Show resolved Hide resolved
@sepandhaghighi sepandhaghighi changed the title fix : status issue fixed in tests. Test Nov 28, 2022
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sepandhaghighi sepandhaghighi merged commit 36085c7 into dev Nov 28, 2022
@sepandhaghighi sepandhaghighi deleted the tests branch November 28, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants