Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed last Resources#getIdentifier calls. #58

Merged
merged 1 commit into from
Feb 14, 2014

Conversation

hborders
Copy link

Replaced the last Resources#getIdentifier calls with ordinary uses of R. This also fixes crashes due to missing resources when the APK package is renamed with aapt's --rename-manifest-package option.

Replaced the last Resources#getIdentifier calls with ordinary uses of R. This also fixes crashes due to missing resources when the APK package is renamed with aapt's --rename-manifest-package option.
sephiroth74 added a commit that referenced this pull request Feb 14, 2014
Removed last Resources#getIdentifier calls.
@sephiroth74 sephiroth74 merged commit e3068a8 into sephiroth74:master Feb 14, 2014
@hborders
Copy link
Author

When I consume the library from maven central and build with maven, everything works fine. However, when I build with IntelliJ (using a project created by importing the maven file), I get NoClassDefFoundErrors when I try to use it.sephiroth.android.library.R.class; This seems like a bug in IntelliJ. When I built from source, everything works fine. Do you have any idea what the problem might be? IntelliJ is definitely trying to download the proper jar.

@sephiroth74
Copy link
Owner

why don't you use the gradle "compile" option in IntellJ? It works fine for me.

@hborders
Copy link
Author

I can't use gradle with IntelliJ because it has no way to run robotium tests. Anyways, I think this is an IntelliJ bug. maven-android-plugin seems to generate R from R.txt in the aar file. IntelliJ doesn't.

@sephiroth74
Copy link
Owner

I'm sorry but I don't use maven at all so I can't help you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants