Add ledger object models #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimpidCrypto
added
enhancement
Closed
22 tasks
sephynox
reviewed
Mar 20, 2023
2 tasks
sephynox
reviewed
Apr 1, 2023
Comment on lines
+20
to
+35
| match flags_value_result { | ||
| Ok(flags_as_value) => { | ||
| let flag_vec_result: Result<Vec<u32>, serde_json::Error> = | ||
| serde_json::from_value(flags_as_value); | ||
| match flag_vec_result { | ||
| Ok(flags_vec) => s.serialize_u32(flags_vec.iter().sum()), | ||
| Err(_) => { | ||
| // TODO: Find a way to use custom errors | ||
| Err(ser::Error::custom("SerdeIntermediateStepError: Failed to turn flags into `Vec<u32>` during serialization")) | ||
| } | ||
| } | ||
| } | ||
| Err(_) => Err(ser::Error::custom( | ||
| "SerdeIntermediateStepError: Failed to turn flags into `Value` during serialization", | ||
| )), | ||
| } |
There was a problem hiding this comment.
I think an if let or pattern binding might make this a bit cleaner.
Comment on lines
+102
to
112
| let flags_vec_result: Result<Vec<F>, D::Error> = deserialize_flags(d); | ||
| match flags_vec_result { | ||
| Ok(flags_vec) => { | ||
| if flags_vec.is_empty() { | ||
| Ok(None) | ||
| } else { | ||
| Ok(Some(flags_vec)) | ||
| } | ||
| } | ||
| Err(error) => Err(error), | ||
| } |
There was a problem hiding this comment.
An if/else would be simpler here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up to #57
High Level Overview of Change
Ledger object models
Adds ledger object models including the
AMMobject model.Models in general
It is also an attempt to implement a general order for fields (models/mod.rs):
If agreed on the order:
serde_with_tagMoved the
Helpertofn serializeandfn deserializeto avoid defining it multiple times in a file.Context of Change
#27
Type of Change
Test Plan
Future Tasks
Keep an eye on the
XRPFeesamendment. It could change how some fields are typed and/or named.