Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IN PROGRESS: Transaction signing #71

Open
wants to merge 62 commits into
base: dev
Choose a base branch
from
Open

IN PROGRESS: Transaction signing #71

wants to merge 62 commits into from

Conversation

LimpidCrypto
Copy link
Collaborator

@LimpidCrypto LimpidCrypto commented Sep 10, 2023 •
edited
Loading

High Level Overview of Change

Adds async transaction signing.

Type of Change

  • New feature (non-breaking change which adds functionality)

Tasks

  • Add auto_fill_txn #76
  • Handle unwraps
  • Complete sign method
  • Write tests
  • Resolve Deserialize lifetime issues
  • Add multi sign support

@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Sep 10, 2023
@LimpidCrypto LimpidCrypto added this to the Add high-level methods milestone Sep 10, 2023
@LimpidCrypto LimpidCrypto self-assigned this Sep 10, 2023
@LimpidCrypto LimpidCrypto linked an issue Sep 10, 2023 that may be closed by this pull request
Add high-level methods for transactions #36
Open
6 tasks
@LimpidCrypto LimpidCrypto mentioned this pull request Sep 18, 2023
Merged
2 tasks
@LimpidCrypto LimpidCrypto mentioned this pull request Jan 5, 2024
Merged
7 tasks
@LimpidCrypto LimpidCrypto mentioned this pull request Jun 18, 2024
Closed
4 tasks
@LimpidCrypto LimpidCrypto mentioned this pull request Aug 10, 2024
Merged
4 tasks
LimpidCrypto and others added 11 commits August 13, 2024 16:32
@LimpidCrypto
add devcontainer
2ac9f2e
@LimpidCrypto
fix async client tests
de27d17
@LimpidCrypto
fix github workflow
0d5f227
@LimpidCrypto
fix tests with --all-features
36c48f9
@LimpidCrypto
fix --no-default-features tests with embedded-ws
551a345
@LimpidCrypto
try fix colliding embebedded-websocket feature with dep: syntax
dec632c
@LimpidCrypto
fix ambiguous name error
20a4eca
@LimpidCrypto
Revise Models (#74)
d13b6ee 
* current state

* initial

* initial

* add to changelog

* impl LedgerObject trait

* remove .DS_Store

* add documentation

* cargo fix

* add Default trait to FlagCollection

* refactoring of models

* fix serde tests

* fix serde tests

* Delete src/models/.DS_Store

* remove dafault_none

* resolve comments
@LimpidCrypto
revise dependencies
32972e9
@LimpidCrypto
remove old clients
5d73fe7
@LimpidCrypto
add new clients
9e53d45
LimpidCrypto and others added 30 commits August 13, 2024 16:33
@LimpidCrypto
revise the tests to work with the changes
f2ab2ff
@LimpidCrypto
error handling
c6bae64
@LimpidCrypto
improve testing
339661e
@LimpidCrypto
implement websocket client request
5cd31fa
@LimpidCrypto
implement websocket client request for embedded websocket
83dabd6
@LimpidCrypto
update rand trying to get rid of cargo check: OsRng: rand_core::RngCo…
2d706f3 
…re is not satisfied error
@LimpidCrypto
fix github workflow build and tests
e43d83e
@LimpidCrypto
fix github workflow build and tests
a38acb9
@LimpidCrypto
run linters
cc40b3a
@LimpidCrypto
add json rpc client
2fa328a
@LimpidCrypto
add json rpc for std and tests
3a673b9
@LimpidCrypto
cargo fmt
70ae10b
@LimpidCrypto
add pre-commit test with json-rpc-std
0111cc3
@LimpidCrypto
cargo fmt
06bd99f
@LimpidCrypto
cargo fix
6fd06a8
@LimpidCrypto
improve client code
1eb8df9
@LimpidCrypto
refactor features
7839018
@LimpidCrypto
fix tungstenite example
19b9473
@LimpidCrypto
fix clients
0a1e81e
@LimpidCrypto
fix client tests
4f0b501
@LimpidCrypto
fix tests
40775ba
@LimpidCrypto
rename features in github workflow
52ff345
@LimpidCrypto
add transaction auto filling as in #76 (#80)
3722232
@LimpidCrypto
current state of txn signing
a42c1b9
@LimpidCrypto
current state of sign
9f06aa3
@LimpidCrypto
current state of sign
2ec5233
@LimpidCrypto
add simple test
2aee4cf
@LimpidCrypto
resolve errors caused by updating branch
6b71337
@LimpidCrypto
resolve errors caused by updating branch
f7abd94
@LimpidCrypto
add autofill_and_sign
12147b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sephynox sephynox Awaiting requested review from sephynox sephynox is a code owner

Assignees

@LimpidCrypto LimpidCrypto

Labels
enhancement New feature or request
Projects
xrpl-rust
Status: 🏗 In progress
Milestone
Add high-level methods
Development

Successfully merging this pull request may close these issues.

Add high-level methods for transactions
1 participant
@LimpidCrypto