Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp files opened externally (e.g. by double click) leaked in temp folder #1629

Closed
lfcnassif opened this issue Apr 11, 2023 · 2 comments
Closed

Temp files opened externally (e.g. by double click) leaked in temp folder #1629

lfcnassif opened this issue Apr 11, 2023 · 2 comments
Assignees
@lfcnassif
Labels
bug

Comments

@lfcnassif
Copy link
Member

lfcnassif commented Apr 11, 2023 •
edited

The UI needs to create temp files to open them externally using the native application, when they are inside E01, Ex01, etc, or to avoid changing files processed from a mounted folder with write permission. Currently we don't try to delete them intentionally, because it may be difficult to know when the user stops to view/handle the temp files externally, but this causes a leak of temp files in user temp dir. I'm not sure if there is a safe way to know if user stopped to view the temp files, maybe deleting them if there is no system file handle opened, or after some time... Ideas?
@wladimirleite
Copy link
Member

Currently, these temporary files are deleted when the analysis application is closed, right?

@lfcnassif
Copy link
Member Author

Hum, good point! Tomorrow I'll check if that is done in all places and I think it may be enough to close this.

@lfcnassif lfcnassif added bug and removed question labels Apr 12, 2023
@lfcnassif lfcnassif self-assigned this Apr 12, 2023
@lfcnassif lfcnassif changed the title Delete temp files created by double click on UI? Delete temp files leaked in temp folder by double click on UI Apr 12, 2023
lfcnassif added a commit that referenced this issue Apr 12, 2023
@lfcnassif
'#1629: delete temp files created by viewers on exit
ba62368
lfcnassif added a commit that referenced this issue Apr 12, 2023
@lfcnassif
'#1629: delete last item clicked/viewed on analysis UI
bc37909
@lfcnassif lfcnassif changed the title Delete temp files leaked in temp folder by double click on UI Delete temp files opened externally (e.g. by double click) leaked in temp folder Apr 12, 2023
@lfcnassif lfcnassif changed the title Delete temp files opened externally (e.g. by double click) leaked in temp folder Delete temp files opened externally (e.g. by double click) being leaked in temp folder Apr 12, 2023
@lfcnassif lfcnassif changed the title Delete temp files opened externally (e.g. by double click) being leaked in temp folder Temp files opened externally (e.g. by double click) leaked in temp folder Apr 12, 2023
lfcnassif added a commit that referenced this issue Apr 13, 2023
@lfcnassif
'#1629: delete temp files created by viewers on exit
54f9006
lfcnassif added a commit that referenced this issue Apr 13, 2023
@lfcnassif
fix #1629: delete temp files created double click on UI
a1f8c15
lfcnassif added a commit that referenced this issue Apr 13, 2023
@lfcnassif
'#1629: delete last item clicked/viewed on analysis UI
55fd18a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfcnassif lfcnassif

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wladimirleite @lfcnassif