Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WhatsApp reactions #1661

Closed
wladimirleite opened this issue Apr 26, 2023 · 2 comments · Fixed by #1651 or #1681
Closed

Support WhatsApp reactions #1661

wladimirleite opened this issue Apr 26, 2023 · 2 comments · Fixed by #1651 or #1681
Assignees
@wladimirleite
Labels
enhancement

Comments

@wladimirleite
Copy link
Member

wladimirleite commented Apr 26, 2023 •
edited

Include reactions associated with messages in the generated WhatsApp chat HTML preview.

Also including who reacted and when could be useful in particular cases.
To avoid making the visualization too long/verbose, this additional information could be shown only when the user hover a reaction element.

An example:
image
@wladimirleite wladimirleite self-assigned this Apr 26, 2023
wladimirleite added a commit that referenced this issue Apr 26, 2023
@wladimirleite
'#1661: Show reactions associated with messages in WA chats (Android).
2147d62
@wladimirleite wladimirleite mentioned this issue Apr 26, 2023
Merged
wladimirleite added a commit that referenced this issue Apr 26, 2023
@wladimirleite
'#1661: Check reaction table existence only once.
dad20e5
wladimirleite added a commit that referenced this issue Apr 26, 2023
@wladimirleite
'#1661: Improve contact information formatting for reactions.
dab64a6
wladimirleite added a commit that referenced this issue Apr 28, 2023
@wladimirleite
'#1661: Show reactions associated with messages in WA chats (iOS).
9cc639d
wladimirleite added a commit that referenced this issue Apr 28, 2023
@wladimirleite
'#1661: Comment debug messages (keep them for now).
c26718f
wladimirleite added a commit that referenced this issue Apr 28, 2023
@wladimirleite
'#1661: Add a TODO about possibly missing owner's reactions.
e6c523d
wladimirleite added a commit that referenced this issue Apr 28, 2023
@wladimirleite
'#1661: WhatsApp CSS changes used for reactions to messages.
19c0cbd
wladimirleite added a commit that referenced this issue May 3, 2023
@wladimirleite
'#1661: Show owner's reactions to WA messages (iOS).
4bc1a6a
wladimirleite added a commit that referenced this issue May 11, 2023
@wladimirleite
'#1661: Always return a not null List when decoding iOS WA ProtoBuf.
19b3ec0
@wladimirleite
Copy link
Member Author

Testing with iOS databases using the most recent WhatsApp version, I noticed that reactions were not extracted.
It uses a blob field with variable data encoded as a Protobuf to store any "additional information" related to a message.
So it is quite annoying to understand and decode.
I found an issue in the decoding process that I implemented, triggered by these new databases.
I am running more tests (with newer and older DBs) to be sure it is more solid now.

@wladimirleite wladimirleite reopened this May 13, 2023
@wladimirleite
Copy link
Member Author

Despite the changes in the newer databases, in fact the issue was caused by the last commit I made (19b3ec0).
I will submit a fix to handle iOS reactions properly.

wladimirleite added a commit that referenced this issue May 13, 2023
@wladimirleite
'#1661: Fix commit 19b3ec0, to handle iOS reactions properly.
b1117ae
@wladimirleite wladimirleite mentioned this issue May 13, 2023
Merged
lfcnassif added a commit that referenced this issue May 13, 2023
@lfcnassif
Merge pull request #1681 from sepinf-inc/#1661_FixWAReactionsiOS
e4b201d 
Fix commit 19b3ec0, to handle iOS reactions properly (#1661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wladimirleite wladimirleite

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@wladimirleite