Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Timeline chart data just when it becomes visible to decrease memory usage by UI #1707

Closed
lfcnassif opened this issue Jun 5, 2023 · 4 comments · Fixed by #1708
Closed

Load Timeline chart data just when it becomes visible to decrease memory usage by UI #1707

lfcnassif opened this issue Jun 5, 2023 · 4 comments · Fixed by #1708
Assignees
@patrickdalla
Labels
enhancement

Comments

@lfcnassif
Copy link
Member

This would avoid breaking the whole UI with OOM errors when large cases are opened, that happens today even if the feature is not used by the user.
@lfcnassif
Copy link
Member Author

Hi @patrickdalla could you try to implement this?

@lfcnassif
Copy link
Member Author

I would like to put this into 4.1.3 to make 4.1.x more stable.

@patrickdalla
Copy link
Collaborator

right

patrickdalla added a commit that referenced this issue Jun 5, 2023
@patrickdalla
'#1707 postpone timeline chart cache creation to the moment the user
f170008 
first opens timeline chart.
@patrickdalla
Copy link
Collaborator

Done and PR created. You can close with the PR.

lfcnassif added a commit that referenced this issue Jun 20, 2023
@lfcnassif
'#1707: removes unused method
b4ff098
lfcnassif added a commit that referenced this issue Jun 20, 2023
@lfcnassif
'#1707: format code
1c265ce
lfcnassif added a commit that referenced this issue Jun 20, 2023
@lfcnassif
'#1707: use a safer atomic flag since it may be set by different Threads
0b24dfb
@lfcnassif lfcnassif linked a pull request Jun 20, 2023 that will close this issue
Postpone timeline chart load #1708
Merged
lfcnassif pushed a commit that referenced this issue Jun 27, 2023
@patrickdalla @lfcnassif
'#1707 postpone timeline chart cache creation to the moment the user
cfa6530 
first opens timeline chart.
lfcnassif pushed a commit that referenced this issue Jun 27, 2023
@patrickdalla @lfcnassif
'#1707 Call cache creation in background not to block UI. Paint loading
098b4d3 
label
on panel.
lfcnassif added a commit that referenced this issue Jun 27, 2023
@lfcnassif
'#1707: removes unused method
b7cc02e
lfcnassif added a commit that referenced this issue Jun 27, 2023
@lfcnassif
'#1707: format code
f1d6f96
lfcnassif added a commit that referenced this issue Jun 27, 2023
@lfcnassif
'#1707: use a safer atomic flag since it may be set by different Threads
0571e61
@lfcnassif lfcnassif changed the title Load Timeline chart data structures just when it becomes visible Load Timeline chart data just when it becomes visible to decrease memory usage by UI Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickdalla patrickdalla

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Postpone timeline chart load sepinf-inc/IPED
2 participants
@lfcnassif @patrickdalla