Import Keyword list as Bookmarks

[gfd2020]

Some users asked me to implement this functionality below. Basically, it's the possibility to create a bookmark for the imported list and/or a bookmark for each word in the imported list. Is there interest in this implementation? It will be very easy.

[lfcnassif]

Thanks @gfd2020, it was already asked by our users too, it would be very useful. But there is an important limitation: bookmarks would not highlight hits in file names or content in the Preview tab when clicking on contained items.

For this feature, I think we should extend the Bookmark class (by a subclass) to keep track of the original keyword term, so it could be used to highlight hits in file names and content.

[lfcnassif]

Maybe we wouldn't need to subclass Bookmarks class, but just use a generic internal Map I added in version 4.0.0 to handle this kind of extension:

IPED/iped-engine/src/main/java/iped/engine/data/Bookmarks.java

Line 72 in 5e59dde

private Map<String, Serializable> extendedBookmarks;

[gfd2020]

Thanks @gfd2020, it was already asked by our users too, it would be very useful. But there is an important limitation: bookmarks would not highlight hits in file names or content in the Preview tab when clicking on contained items.

For this feature, I think we should extend the Bookmark class (by a subclass) to keep track of the original keyword term, so it could be used to highlight hits in file names and content.

Do you think this is expected behavior?

I made a PR. #1771. No highlighs now ... needs to be implemented.

[lfcnassif]

Do you think this is expected behavior?

No highlights is the Bookmarks expected behavior today. But my concern about this feature is encouraging users to click on Bookmarks instead of on Keywords List Combobox in the search bar and miss the very useful highlights, which are very important for users in my opinion.

[gfd2020]

Do you think this is expected behavior?

No highlights is the Bookmarks expected behavior today. But my concern about this feature is encouraging users to click on Bookmarks instead of on Keywords List Combobox in the search bar and miss the very useful highlights, which are very important for users in my opinion.

I see. I think it's a difficult decision.

[hilderonny]

Is there any progress to this functionality? Our users also requested such a behaviour. They have a keyword list for international terrorism containing over 600 words in different languages and idioms. Importing this list as keyword list is not elegant enough because you need to perform a separate search for every term and create a bookmark for it manually.

Especially for creating HTML reports it would be very comfortable to create a report by selecting all of the imported search-term-bookmarks and see them in the output.

[gfd2020]

Is there any progress to this functionality? Our users also requested such a behaviour. They have a keyword list for international terrorism containing over 600 words in different languages and idioms. Importing this list as keyword list is not elegant enough because you need to perform a separate search for every term and create a bookmark for it manually.

Especially for creating HTML reports it would be very comfortable to create a report by selecting all of the imported search-term-bookmarks and see them in the output.

The first implementation is ready. Now all that is needed is the review.

[lfcnassif]

Hi @hilderonny and @gfd2020! I'll try to review #1771 when I return from vacation next week. In my opinion, it would be important to implement keywords highlighting when clicking on bookmarks created from keywords, as I explained above, but maybe that can be left as a future improvement.

[lfcnassif]

Hi @gfd2020. I just reviewed #1771 and it worked fine! I just changed a bit the FileChooser layout to show the new checkboxes in a vertical layout, I think users will notice the new options easier, adjusted localization strings to be more intuitive and added a bookmark name prefix and comments:

I'll leave hit highlighting when filtering by the new keyword bookmarks as a future improvement.