Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TwelveMonkeys to 3.10 #1966

Closed
wladimirleite opened this issue Nov 6, 2023 · 5 comments · Fixed by #1970
Closed

Upgrade TwelveMonkeys to 3.10 #1966

wladimirleite opened this issue Nov 6, 2023 · 5 comments · Fixed by #1970
Assignees
Labels
dependencies Pull requests that update a dependency file task

Comments

@wladimirleite
Copy link
Member

wladimirleite commented Nov 6, 2023

Recently a new version of TwelveMonkeys library was released:
https://github.com/haraldk/TwelveMonkeys/releases/tag/twelvemonkeys-3.10.0
It includes fixes and enhancements for formats that we use its plugins (WEBP, PSD and TIFF).

Testing with a large set of images I have come to these conclusions (comparing thumb creation task):

  • WEBP (115,000): Rendering improved a lot for ~3,000 images. Before these images were not rendered at all, just a full white or black area, or rendered very poorly. No performance change;
  • PSD (1,500): 2 more images were rendered, slightly faster (~10%), but 4 images caused a critical issue (described later);
  • TIFF (2,200): 10 images were rendered much better (white rectangle before). Slightly faster (~10%);
  • ICO (300): No changes.

So overall the new release is better, except for a critical issue that happened with 4 malformed (incomplete or corrupted) PSD images. Before (with version 3.9.4) "something" was rendered, but with the new version (3.10.0) it doesn't return from the ImageIO.read() function. For the ThumbTask there is a timeout that takes care of it, but it causes a strange (unresponsive viewer) behavior when opening these images in the analysis GUI.
I will open an issue in the TwelveMonkeys project.

@wladimirleite wladimirleite added dependencies Pull requests that update a dependency file task labels Nov 6, 2023
@wladimirleite wladimirleite self-assigned this Nov 6, 2023
@wladimirleite
Copy link
Member Author

An example of PSD that cause the issue with 3.10.0:
corrupted-psd.zip

This is how its thumbnail was rendered with 3.9.4:
image

@wladimirleite
Copy link
Member Author

@wladimirleite
Copy link
Member Author

The issue was fixed already. There should be a 3.10.1 bug fix release soon. When it is available, I will repeat the tests.

@wladimirleite
Copy link
Member Author

  • WEBP (115,000): Rendering improved a lot for ~3,000 images. Before these images were not rendered at all, just a full white or black area, or rendered very poorly.

Just for the sake of completeness, an example of a WEBP that is rendered much better with the newer version (sample-webp.zip):

3.9.4
image

3.10.0
image

@lfcnassif
Copy link
Member

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants